[Bug 693493] Review Request: thunderbird-lightning - The calendar extension to Thunderbird

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693493

Matej Cepl <mcepl at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(orion at cora.nwra.c
                   |                            |om)

--- Comment #12 from Matej Cepl <mcepl at redhat.com> 2011-04-20 17:24:30 EDT ---
(In reply to comment #7)
> Fixed.  Note that this was copied from the current thunderbird package so is
> an issue there.

Thanks, I have never said that our packages are the pinnacle of purity and
quality. Unfortunately.

> > thunderbird-lightning.src: W: strange-permission find-external-requires 0755L
> > A file that you listed to include in your package has strange permissions.
> > Usually, a file should have 0644 permissions.
> 
> I think this has to be executable to work.

Agree.

> > thunderbird-lightning-debuginfo.x86_64: E: empty-debuginfo-package
> 
> I'm a bit at a loss.  This appears to be because libcalbasecomps.so is getting
> stripped by the mozilla build/install process, but I can't figure out where. 
> Any help would be appreciated.

Did that STRIP=/bin/true help? I am afraid, until we fix this, I won't let this
package to go.

> > + BAD : Runs rm -rf $RPM_BUILD_ROOT in %install
> > It doesn't.
> 
> Not needed in F15, but since we have requests for F13/F14 I added it.

I would just note that this may end in EPEL as well, actually may I ask to make
sure there will be EPEL-6 branch, please? (I would use it for for my wife's
notebook ;)).

With exception of the debuginfo the rest is OK. Waiting on reply about that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.