[Bug 672205] Review Request: pynag - Python Nagios plugin and configuration environment

Thu Apr 21 00:26:44 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=672205

PRABIN KUMAR DATTA <linux.n.pkd at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |linux.n.pkd at gmail.com

--- Comment #3 from PRABIN KUMAR DATTA <linux.n.pkd at gmail.com> 2011-04-20 20:26:43 EDT ---
^ This is an Informal Review. ^

* MUST: rpmlint must be run on every package                           [Fix  ]

$ rpmlint -i SRPMS/pynag-0.3-2.src.rpm 
pynag.src: W: non-coherent-filename pynag-0.3-2.src.rpm
pynag-0.3-2.fc13.src.rpm
The file which contains the package should be named
<NAME>-<VERSION>-<RELEASE>.<ARCH>.rpm.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint -i RPMS/noarch/pynag-0.3-2.fc14.noarch.rpm 
pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/remove_host_from_group.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/find_orphans.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/network_scan.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_contactgroup.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/parse_files.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_hostgroup.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_service_info.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/check_cpu.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_servicegroup.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/optimize_config.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/list_services.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/remove_host.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_command.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_service.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_contact.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_host.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/get_timeperiod.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/suggest_optimizations.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

pynag.noarch: W: spurious-executable-perm
/usr/share/doc/pynag-0.3/examples/list_hosts_groups.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

1 packages and 0 specfiles checked; 0 errors, 19 warnings.

* MUST: The package must be named according to the Package Naming    [Fix   ] 
  Guidelines
Check rpmlint output for pynag-0.3-2.src.rpm

* MUST: The spec file for the package MUST be legible.               [Fix   ] 

* Must: Spec file matches base package                               [OK   ] 

* Must: License must be licensed with a Fedora approved license and meet the
  Licensing Guidelines                                               [OK   ]

* Must: License in spec must match actual license                    [OK   ] 

* Must: License file included in %doc                                [OK   ]

* Must: Spec file written in American English                        [OK   ]

* Must: Tar ball matches upstream                                    [OK   ]

* Must: Package successfully builds binary RPMs                      [OK   ]
local build -(f14)
Koji build -(f15) http://koji.fedoraproject.org/koji/taskinfo?taskID=3014787

* Must: No duplicate files                                           [OK   ]

* Must: Macro use must be consistant                                 [OK   ]
Thou, for example:
%dir %{python_sitelib}/pynag
Can be written as
%dir %{python_sitelib}/%{name}

* Must: At the beginning of %install, each package MUST run rm -rf %{buildroot}
                                                                     [OK   ]

* Must: All filenames in rpm packages must be valid UTF-8            [OK   ]

* Other: %clean section and rm -fr $RPM_BUILD_ROOT are not required for F-13
and above. http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.