[Bug 673585] Review Request: perl-Apache-Htgroup - Manage Apache htgroup files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=673585

PRABIN KUMAR DATTA <linux.n.pkd at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |linux.n.pkd at gmail.com

--- Comment #5 from PRABIN KUMAR DATTA <linux.n.pkd at gmail.com> 2011-04-20 21:49:06 EDT ---
* MUST: rpmlint must be run on every package                         [Fix  ]
--/Rpmlint output/--
$ rpmlint -i RPMS/noarch/perl-Apache-Htgroup-1.23-1.fc14.noarch.rpm 
perl-Apache-Htgroup.noarch: W: invalid-license Artistic
The value of the License tag was not recognized.  Known values are: "AAL",
"Adobe", "ADSL", "AFL", "AGPLv1", "AGPLv3", "AGPLv3 with exceptions",
"AMDPLPA", "AML", "AMPAS BSD", "APSL 2.0", "APSL 2.0+", "ARL", "Artistic 2.0",
"Artistic clarified", "ASL 1.0", "ASL 1.0+", "ASL 1.1", "ASL 1.1+", "ASL 2.0",
"ASL 2.0+", "Beerware", "BeOpen", "BitTorrent", "Boost", "BSD", "BSD
Protection", "BSD with advertising", "CATOSL", "CC0", "CeCILL", "CeCILL-B",
"CeCILL-C", "CDDL", "CNRI", "Condor", "Copyright only", "CPAL", "CPL",
"Crystal Stacker", "DOC", "dvipdfm", "ECL 1.0", "ECL 2.0", "eCos", "EFL 2.0",
"EFL 2.0+", "Entessa", "EPL", "ERPL", "EU Datagrid", "EUPL 1.1", "Eurosym",
"Fair", "FTL", "Giftware", "GL2PS", "Glide", "gnuplot", "GPL+", "GPL+ or
Artistic", "GPL+ with exceptions", "GPLv1", "GPLv2 or Artistic", "GPLv2+ or
Artistic", "GPLv2", "GPLv2 with exceptions", "GPLv2+", "GPLv2+ with
exceptions", "GPLv3", "GPLv3 with exceptions", "GPLv3+", "GPLv3+ with
exceptions", "IBM", "IJG", "ImageMagick", "iMatix", "Imlib2", "Intel ACPI",
"Interbase", "ISC", "Jabber", "JasPer", "JPython", "Knuth", "LBNL BSD",
"LGPLv2", "LGPLv2 with exceptions", "LGPLv2+", "LGPLv2+ or Artistic", "LGPLv2+
with exceptions", "LGPLv3", "LGPLv3 with exceptions", "LGPLv3+", "LGPLv3+ with
exceptions", "libtiff", "LLGPL", "Logica", "LPL", "LPPL", "mecab-ipadic",
"MirOS", "MIT", "MIT with advertising", "mod_macro", "Motosoto", "MPLv1.0",
"MPLv1.0+", "MPLv1.1", "MPLv1.1+", "MS-PL", "MS-RL", "Naumen", "NCSA",
"NetCDF", "Netscape", "Newmat", "NGPL", "Nokia", "NOSL", "Noweb", "OML",
"OpenLDAP", "OpenPBS", "OpenSSL", "OReilly", "OSL 1.0", "OSL 1.0+", "OSL 1.1",
"OSL 1.1+", "OSL 2.0", "OSL 2.0+", "OSL 2.1", "OSL 2.1+", "OSL 3.0", "OSL
3.0+", "Phorum", "PHP", "PlainTeX", "Plexus", "PostgreSQL", "psutils", "Public
Domain", "Python", "Qhull", "QPL", "Rdisc", "RiceBSD", "Romio", "RPSL",
"Ruby", "Saxpath", "SCEA", "SCRIP", "Sendmail", "Sleepycat", "SISSL", "SLIB",
"SNIA", "SPL", "TCL", "Teeworlds", "TMate", "TOSL", "TPL", "UCD", "Vim",
"VNLSL", "VOSTROM", "VSL", "W3C", "Webmin", "WTFPL", "wxWidgets", "Xerox",
"xinetd", "XSkat", "YPLv1.1", "Zend", "zlib", "zlib with acknowledgement",
"ZPLv1.0", "ZPLv1.0+", "ZPLv2.0", "ZPLv2.0+", "ZPLv2.1", "ZPLv2.1+", "CDL",
"FBSDDL", "GFDL", "IEEE", "LDPL", "OFSFDL", "Open Publication", "Public Use",
"CC-BY", "CC-BY-ND", "CC-BY-SA", "DMTF", "DSL", "EFML", "Free Art",
"GeoGratis", "Green OpenMusic", "OAL", "AMS", "Arphic", "Baekmuk", "Bitstream
Vera", "DoubleStroke", "Hershey", "IPA", "Liberation", "Lucida", "MgOpen",
"mplus", "OFL", "PTFL", "STIX", "Utopia", "Wadalab", "XANO", "Redistributable,
no modification permitted", "Freely redistributable without restriction".

perl-Apache-Htgroup.noarch: W: invalid-license GPL, see LICENSE
--skiped same as above--

1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint -i SRPMS/perl-Apache-Htgroup-1.23-1.fc15.src.rpm 
--skiped same as rpmlint output for rpm file--

1 packages and 0 specfiles checked; 0 errors, 2 warnings.

=> it should have to be
 ..................................
| License:       GPLv2 or Artistic |
 ..................................

* MUST: The package must be named according to the Package Naming    [OK  ] 
  Guidelines
Check rpmlint output for pynag-0.3-2.src.rpm

* MUST: The spec file for the package MUST be legible.               [OK  ] 


* Must: Spec file matches base package                               [OK   ] 

* Must: License must be licensed with a Fedora approved license and meet the
  Licensing Guidelines                                               [Fix  ]
=> Check rpmlint warnings

* Must: License in spec must match actual license                    [Fix  ] 
=> Check rpmlint warnings

* Must: License file included in %doc                                [OK   ]

* Must: Spec file written in American English                        [OK   ]

* Must: Tar ball matches upstream                                    [OK   ]

* Must: Package successfully builds binary RPMs                      [OK   ]
local build -(f14)
Koji build -(f15) http://koji.fedoraproject.org/koji/taskinfo?taskID=3014888

* Must: No duplicate files                                           [OK   ]

* Must: Macro use must be consistant                                 [OK   ]
Thou,
"Apache-Htgroup" can be replaced by
1. define a macro at the top
 ...............................................
|%define  realname  Apache-Htgroup|
 ...............................................
2. use %{realname} in place of Apache-Htgroup


* Must: At the beginning of %install, each package MUST run rm -rf %{buildroot}
                                                                     [OK   ]

* Must: All filenames in rpm packages must be valid UTF-8            [OK   ]

* Other: %clean section and rm -fr $RPM_BUILD_ROOT are not required for F-13
and above. http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.