[Bug 697780] Review Request: rubygem-daemon_controller - A library for implementing daemon management capabilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=697780

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Parag AN(पराग) <panemade at gmail.com> 2011-04-21 03:11:15 EDT ---
Review:

+ koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3015387

+ Upstream source verified as (sha1sum)
929a9c6b62777eabff49cb83821bba4d43e1ea57  daemon_controller-0.2.5.gem
929a9c6b62777eabff49cb83821bba4d43e1ea57 
../SOURCES/daemon_controller-0.2.5.gem

+ rpmlint gave
rubygem-daemon_controller-doc.noarch: W: no-documentation
rubygem-daemon_controller-doc.noarch: E: zero-length
/usr/lib/ruby/gems/1.8/gems/daemon_controller-0.2.5/spec/echo_server.pid.lock
rubygem-daemon_controller-doc.noarch: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/daemon_controller-0.2.5/ri/DaemonController/running%3f-i.yaml
%3f
3 packages and 0 specfiles checked; 1 errors, 2 warnings.

==> I think its ok to have echo_server.pid.lock as zero-length file.

Suggestions:
1) Looks I missed to add following to -doc instead of main package
 %{geminstdir}/*.gemspec


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.