[Bug 593559] Review Request: protobuf-c - C bindings for Google's Protocol Buffers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593559

--- Comment #21 from David Robinson <zxvdr.au at gmail.com> 2011-04-21 06:09:56 EDT ---
Updated spec and srpm are here:

Spec URL: http://zxvdr.fedorapeople.org/RPMS/protobuf-c/protobuf-c.spec
SRPM URL:
http://zxvdr.fedorapeople.org/RPMS/protobuf-c/protobuf-c-0.15-1.fc14.src.rpm

I've asked upstream if they can include the license in the tarball:
http://groups.google.com/group/protobuf-c/t/27fabd55539f1a54

make %{?_smp_mflags} seems to work when the package is built in mock.

The changelog changes are to make the format consistent w/ rpmdev-bumpspec.

--- protobuf-c.spec.orig 2011-04-20 06:50:12.181661465 +1000
+++ protobuf-c.spec 2011-04-20 07:54:39.366528303 +1000
@@ -1,19 +1,20 @@
 Name:           protobuf-c
-Version:        0.14
+Version:        0.15
 Release:        1%{?dist}
 Summary:        C bindings for Google's Protocol Buffers

-Group:          Development/Libraries
+Group:          System Environment/Libraries
 License:        ASL 2.0
 URL:            http://code.google.com/p/protobuf-c/
 Source0:       
http://protobuf-c.googlecode.com/files/protobuf-c-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+Source1:        http://protobuf-c.googlecode.com/svn/tags/%{version}/LICENSE

 BuildRequires:  protobuf-devel

 %description
-This package provides a code generator and runtime libraries to use Protocol
-Buffers from pure C (not C++).
+Protocol Buffers are a way of encoding structured data in an efficient yet 
+extensible format. This package provides a code generator and run-time
+libraries to use Protocol Buffers from pure C (not C++).

 It uses a modified version of protoc called protoc-c. 

@@ -23,10 +24,11 @@
 Requires:       %{name} = %{version}-%{release}

 %description devel
-This package contains protobuf-c headers and libraries
+This package contains protobuf-c headers and libraries.

 %prep
 %setup -q
+cp %{SOURCE1} .

 %build
 %configure --disable-static
@@ -36,21 +38,17 @@
 make check

 %install
-rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
 rm -f $RPM_BUILD_ROOT/%{_libdir}/libprotobuf-c.la

 %post -p /sbin/ldconfig
 %postun -p /sbin/ldconfig

-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %files
 %defattr(-,root,root,-)
 %{_bindir}/protoc-c
 %{_libdir}/libprotobuf-c.so.*
-%doc TODO ChangeLog
+%doc TODO LICENSE ChangeLog

 %files devel
 %defattr(-,root,root,-)
@@ -59,13 +57,17 @@
 %{_libdir}/pkgconfig/libprotobuf-c.pc

 %changelog
-* Mon Jan 17 2011 Bobby Powers <bobby at laptop.org> 0.14-1
+* Wed Apr 20 2011 David Robinson <zxvdr.au at gmail.com> - 0.15-1
+- New upstream release
+- Spec file cleanup
+
+* Mon Jan 17 2011 Bobby Powers <bobby at laptop.org> - 0.14-1
 - New upstream release
 - Removed -devel dependency on protobuf-devel
 - Small specfile cleanups

-* Wed May 19 2010 David Robinson <zxvdr.au at gmail.com> 0.13-2
+* Wed May 19 2010 David Robinson <zxvdr.au at gmail.com> - 0.13-2
 - Spec file cleanup

-* Wed May 19 2010 David Robinson <zxvdr.au at gmail.com> 0.13-1
+* Wed May 19 2010 David Robinson <zxvdr.au at gmail.com> - 0.13-1
 - Initial packaging

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.