[Bug 593559] Review Request: protobuf-c - C bindings for Google's Protocol Buffers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593559

--- Comment #22 from Martin Gieseking <martin.gieseking at uos.de> 2011-04-21 09:01:23 EDT ---
Here's the formal review. There's just one thing left to be fixed:
The devel package owns directory %{_includedir}/google/protobuf-c/ but not its
parent %{_includedir}/google/. You can fix this by adding
  %dir %{_includedir}/google/
to the devel package. %{_includedir}/google/ is also co-owned by several
unrelated packages.


$ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm
protobuf-c.src: W: spelling-error %description -l en_US protoc -> proton,
protocol, protochordate
protobuf-c.src: W: invalid-url Source0:
http://protobuf-c.googlecode.com/files/protobuf-c-0.15.tar.gz HTTP Error 404:
Not Found
protobuf-c.x86_64: W: spelling-error %description -l en_US protoc -> proton,
protocol, protochordate
protobuf-c.x86_64: W: no-manual-page-for-binary protoc-c
protobuf-c-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 5 warnings.

All the warnings are expected or false positive and can be ignored.


---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    - ASL 2.0 according to source file headers

[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum protobuf-c-0.15.tar.gz*
    73ff0c8df50d2eee75269ad8f8c07dc8  protobuf-c-0.15.tar.gz
    73ff0c8df50d2eee75269ad8f8c07dc8  protobuf-c-0.15.tar.gz.1

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[+] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[X] MUST: A package must own all directories that it creates.
    - the devel package currently doesn't own %{_includedir}/google/

[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[+] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[+] MUST: If a package contains library files with a suffix, .so (without
suffix) must go in a -devel package.
[+] MUST: devel packages must require the base package using a fully versioned
dependency.
[+] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[+] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The reviewer should test that the package functions as described.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[+] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[.] SHOULD: Your package should contain man pages for binaries/scripts.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.