[Bug 651521] Review Request: qtwebkit - Qt WebKit bindings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651521

--- Comment #3 from Jaroslav Reznik <jreznik at redhat.com> 2011-04-22 11:10:18 EDT ---
Name: ok (upstream)
Group: ok
License: ok
URL: ok
Sources: ok, custom prepared, documented
Summary/description: not sure "Qt WebKit bindings" makes sense here, maybe "Qt
WebKit browser engine" sounds better

Patches: ok
BRs, reqs: ok
Provides, obsoletes: please, provide qt-webkit

SMP Flags: ok, present
Ldconfig snippets: ok, present
File attributes: ok

Consistent macro usage: ok
Devel package: ok, with correct Conflicts, Obsoletes. Is it enough to provide
qt4-webkit-devel and not qt-webkit-devel?

Package builds in Koji: ok,
http://koji.fedoraproject.org/koji/taskinfo?taskID=3019200

rpmlint output:

rpmlint qtwebkit-2.1-2.fc16.src.rpm 
qtwebkit.src: W: invalid-url Source0:
qtwebkit-developers-qtwebkit-qtwebkit-2.1.0.tar.xz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

rpmlint qtwebkit-2.1-2.fc16.x86_64.rpm 
qtwebkit.x86_64: W: obsolete-not-provided qt-webkit
> please fix
qtwebkit.x86_64: W: no-documentation
> ok
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.