[Bug 699209] Review Request: perl-ORLite-Mirror - Extend ORLite to support remote SQLite databases

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=699209

--- Comment #2 from Iain Arnell <iarnell at gmail.com> 2011-04-25 02:52:58 EDT ---
(In reply to comment #1)
> [x] MUST: The spec file must be written in American English.
>     - Please correct the small spelling error.

fixed: readonly -> read-only

> [x] MUST: Packages must not own files or directories already owned by other
> packages.
> 
> %{perl_vendorlib}/*
> %{_mandir}/man3/*
> 
> Your package owns the folders according to the macros. You should use some more
> special folders here, e.g. %{_mandir}/man3/ORLite::Mirror.3pm.*. Use the
> asterisk anyway because we don't refer to a certain compression format here.

This is standard practice for perl modules and mandated in the guidelines:
https://fedoraproject.org/wiki/Packaging:Perl#Directory_Ownership


Spec URL: http://fedorapeople.org/~iarnell/review/perl-ORLite-Mirror.spec
SRPM URL:
http://fedorapeople.org/~iarnell/review/perl-ORLite-Mirror-1.20-2.fc16.src.rpm

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3023633

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.