[Bug 697697] Review Request: sugar-surf - Web Browser activity for Sugar

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=697697

Sergio Pascual <sergio.pasra at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #3 from Sergio Pascual <sergio.pasra at gmail.com> 2011-04-25 18:44:38 EDT ---
Package is APPROVED, anyway there's one thing that should be fixed. COPYING
appears twice, once in doc and another one in
/usr/share/sugar/activities/Surf.activity/COPYING

+ rpmlint says
sugar-surf.noarch: W: non-standard-group Sugar/Activities
sugar-surf.noarch: E: invalid-lc-messages-dir
/usr/share/locale/cpp/LC_MESSAGES/org.laptop.Surf.mo This one can be safely
ignored 
sugar-surf.src: W: non-standard-group Sugar/Activities

+ naming is ok (follows sugar guidelines)
+ Spec file name matches package name
+ Package meets the Packaging Guidelines
+ License is ok (GPLv2+)
+ License text is included in doc
+ Spec file in American English, it is legible
+ Source matches upstream
+ Package builds
+ Build dependencies are listed
+ Locales are handled using %find_lang
+ Package doesn't bundle system libraries
+ Package owns directories it creates (Surf.activity) --
- Files are not duplicated in %files

COPYING appears twice, once in doc and another one in
/usr/share/sugar/activities/Surf.activity/COPYING

+ Permissions are set properly
+ Macros are used consistently
+ Package contains code
+ Builds in mock

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.