[Bug 694287] Review Request: openCOLLADA - 3D import and export libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=694287

--- Comment #31 from Hans de Goede <hdegoede at redhat.com> 2011-04-26 15:30:29 EDT ---
Created attachment 495019
  --> https://bugzilla.redhat.com/attachment.cgi?id=495019
PATCH: add soname to cmake build files, hide util libs

Hi,

So I've been working on the weak non resolved symbols issue, and I noticed
there were CMakeList files already present, and they already contained all the
bits needed to properly link the libs to each other to avoid the weak non
resolved symbols issue.

So I gave the cmake buildsys a spin and it works well, working with cmake is so
much easier then scons :)

So I did a small patch fixing 2 things with the cmake buildsys:
1) Add a proper soname to the build libraries
2) the libBuffer libftoa and libUTF8 libs were only being used in one other
   openCOLLADA lib each, and have very generic names. So instead of building
   them as libs, I've changed the buildsys to embed them into the libs using
   them.

If you use the attached patch (and drop the sconstruct patches) and replace the
%build section with:
%cmake -DUSE_STATIC=OFF -DUSE_SHARED=ON -Dsoversion=svn%{AGE}
# Note building with _smp_mflags does not work for some reason ...
make

Then you'll find properly build libs (including soname + symlinks) under the
lib subdir, make install does not work, it looks like the cmake files need some
work to get this to work, but we can just do it manually for now.

Using cmake with this patch seems to fix all "large things" mentioned in my
full review comment :) I hope you're ok with moving to cmake for building ...

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.