[Bug 696249] Review Request: kupfer - an interface for quick and convenient access to applications and their documents.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=696249

Mario Blättermann <mariobl at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mariobl at freenet.de

--- Comment #2 from Mario Blättermann <mariobl at freenet.de> 2011-04-27 06:55:24 EDT ---
Koji scratch build is here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3029322

$ rpmlint -v *
kupfer-debuginfo.i686: I: checking
kupfer-debuginfo.i686: I: checking-url http://kaizer.se/wiki/kupfer/ (timeout
10 seconds)
kupfer-debuginfo.i686: E: empty-debuginfo-package
kupfer-plugins.i686: I: checking
kupfer-plugins.i686: I: checking-url http://kaizer.se/wiki/kupfer/ (timeout 10
seconds)
kupfer.spec: I: checking-url
http://kaizer.se/publicfiles/kupfer/kupfer-v205.tar.gz (timeout 10 seconds)
kupfer.src: I: checking
kupfer.src: I: checking-url http://kaizer.se/wiki/kupfer/ (timeout 10 seconds)
kupfer.src: E: unknown-key (MD5
kupfer.src: I: checking-url
http://kaizer.se/publicfiles/kupfer/kupfer-v205.tar.gz (timeout 10 seconds)
kupfer.i686: I: checking
kupfer.i686: I: checking-url http://kaizer.se/wiki/kupfer/ (timeout 10 seconds)
kupfer.i686: W: only-non-binary-in-usr-lib
kupfer.i686: E: standard-dir-owned-by-package /usr/bin
kupfer.i686: E: standard-dir-owned-by-package /usr/share/man/man1
kupfer.i686: E: standard-dir-owned-by-package /usr/share/icons
4 packages and 1 specfiles checked; 5 errors, 1 warnings.

Thee last three lines are important. Your package owns folders which are
already owned by other packages.

The files sections should look like this:

# main
%files -f %{name}.lang
%defattr(-,root,root,-)
%doc COPYING GIT_VERSION NEWS README.rst
%doc Documentation/*
%{_bindir}/%{name}
%{_bindir}/%{name}-exec
%{_datadir}/applications/%{name}.desktop
%{_datadir}/applications/%{name}-exec.desktop
%{_datadir}/gnome/help/%{name}/*
%{_datadir}/icons/hicolor/scalable/apps/%{name}.svg
%{_datadir}/mime/packages/%{name}-mimetypes.xml
%{_datadir}/%{name}/*
%{_libdir}/nautilus/extensions-2.0/*
%{_mandir}/man1/%{name}-exec.1.*
%{_mandir}/man1/%{name}.1.*

# plugins
%files plugins
%defattr(-,root,root,-)
%doc COPYING
%{_datadir}/%{name}/%{name}/plugin/*
%dir %{_datadir}/%{name}/searchplugins 
%{_datadir}/%{name}/searchplugins/*

It is not needed to list all the certain files explicitely, if the package owns
their folders anyway. Kupfer behaves somewhat different from other python
packages, which use %{python_sitelib}.

Kupfer doesn't ship any architecture depending files, that's why add
"BuildArch: noarch" to the header. That's the reason for the empty debug
package.

Koji scratch build with the changed file lists:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3029425
(still without "noarch" declaration)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.