[Bug 694287] Review Request: openCOLLADA - 3D import and export libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=694287

--- Comment #44 from Hans de Goede <hdegoede at redhat.com> 2011-04-27 10:58:17 EDT ---
Hi,

(In reply to comment #41)
> 1. Right now I'm getting the wrong library permissions. 775 instead of 755. I'm
> guessing I could fix this with install instead of cp -a but is there an easy
> way to tell cmake to do the right thing?

Weird, it does not do that for me, maybe a difference in the cmake version we
have (I'm on Fedora 15).

(In reply to comment #43)
> Ok, fixed the permissions on the libraries with "install -p -m 0755..."

Good

> left the symlinks as "cp -a" since they need 777, right?

symlinks are always 777, but anything but cp -a will probably copy / install
the files they point to rather then the links, so keeping cp -a for them is the
right thing to do.

> NEW SRPMS URL:
> https://docs.google.com/leaf?id=0B4A6of0Rl4nUMjJhZDNkNzAtNzI2MC00MmIyLTkyMTktMWQwMWY1ZWZhYzZm&hl=en

Almost there, but still needs some work:

* Please drop everything in the spec file above Name: except for the %define of
  AGE, the rest is no longer needed

* Please drop Patch1 and Patch2 they are not needed, they patch SConscript
  files which are only used by scons ...

* Please drop "License:        MIT" from the -devel subpackage, since it
  is the same as for the main package (I missed that before)

* Remove %{?_smp_mflags} from your make invocation, otherwise the build fails
  at least it does so consistently on my quad core.
  Funny how you kept the comment from me snippet saying that the build breaks,
  but re-added the %{?_smp_mflags} :)

* You're still installing header files from the common dir, resulting in
  unittest and performance test headers ending up under /usr/include, but
  see the next item for a more radical suggestion for re-arranging the
  headers.

* And last, one slightly larger issue (which I should have checked before).
  I'm not really happy with putting a bunch of the .h files directly under
  /usr/include. Ideally (IMHO) COLLADAfoo/include/* should end up as
  /usr/include/COLLADAfoo/* for all variants of foo

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.