[Bug 699902] Review Request: python-manuel - Build tested documentation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=699902

--- Comment #2 from Jerry James <loganjerry at gmail.com> 2011-04-27 12:53:29 EDT ---
Thanks for the review!

(In reply to comment #1)
> [-] According to setup.py, this package does not require python-zope-testing at
> runtime.

I did a grep for imports and found this:

import zope.testing.renormalizing

in tests.py, hence the Requires.  On a second look, though, that file is only
used to test manuel itself.  It probably shouldn't be installed, then.  I'll
ask upstream about that.

> [=] Group better be Development/Libraries

Okay.

> [-] The text files in python site path are compiled to html by sphinx and
> included in %doc. They should be excluded from python site path.

Okay.

New version:
http://jjames.fedorapeople.org/python-manuel/python-manuel.spec
http://jjames.fedorapeople.org/python-manuel/python-manuel-1.5.0-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.