[Bug 629324] Review Request: python-zc-buildout - System for managing development buildouts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=629324

Jerry James <loganjerry at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Jerry James <loganjerry at gmail.com> 2011-04-27 13:40:51 EDT ---
I like your marking convention for reviews, so I'll use that below with one
addition:

+:ok
=:needs attention
-:needs fixing
N:not applicable (N/A)

MUST Items:
[+] MUST: rpmlint must be run on every package.
$ rpmlint python-zc-buildout.spec python-zc-buildout
python-zc-buildout.noarch: W: spelling-error Summary(en_US) buildouts -> build
outs, build-outs, buildups
python-zc-buildout.noarch: W: no-manual-page-for-binary buildout
1 packages and 1 specfiles checked; 0 errors, 2 warnings.

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
$ md5sum zc.buildout-1.5.2.tar.gz
87f7b3f8d13926c806242fd5f6fe36f7  zc.buildout-1.5.2.tar.gz

[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[N] MUST: If the package does not build on some arch, it must be listed in
ExcludeArch.
[+] MUST: All build dependencies must be listed in BuildRequires.
[N] MUST: Locales must be handled properly.
[N] MUST: ldconfig must be called for all subpackages that install libraries.
[+] MUST: No copies of system libraries may be installed.
[+] MUST: The package must not be relocatable.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[N] MUST: Large documentation should go into a separate -doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[N] MUST: Header files must be in a -devel package.
[N] MUST: Static libraries must be in a -static package.
[N] MUST: If there are files named *.so.*, then files named *.so must go in
-devel.
[N] MUST: Packages must not contain any libtool archives.
[N] MUST: Packages containing GUI applications must include a desktop file.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[=] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[N] SHOULD: The description and summary sections should contain non-English
translations, if available.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures (I tested i686 and x86_64).
[+] SHOULD: The reviewer should test that the package functions as described.
[N] SHOULD: If scriptlets are used, those scriptlets must be sane.
[N] SHOULD: Subpackages other than devel should require the main package.
[N] SHOULD: Sane placement of pkgconfig files.
[N] SHOULD: Replace some file dependencies with package dependencies.
[=] SHOULD: The package should contain man pages for binaries/scripts.

All MUST items are okay.  Please consider the two SHOULD items marked above,
but I won't hold up approval of the package for them.

This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.