[Bug 694287] Review Request: openCOLLADA - 3D import and export libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=694287

--- Comment #47 from Richard Shaw <hobbes1069 at gmail.com> 2011-04-27 14:17:46 EDT ---
(In reply to comment #46)
> Anyways it is best to just not use %{?_smp_mflags} in this case to avoid build
> failures on for example the buildsystem.

Removed.


> > > * You're still installing header files from the common dir, resulting in
> > >   unittest and performance test headers ending up under /usr/include, but
> > >   see the next item for a more radical suggestion for re-arranging the
> > >   headers.
> > 
> > Should I remove common in addition to the below suggestion?
> 
> s/remove/not install headers from/ -> yes

Done.


> Something like this should do the trick:
> 
> for i in COLLADABaseUtils COLLADAFramework COLLADAMax COLLADAMaya \
>          COLLADASaxFrameworkLoader COLLADAStreamWriter GeneratedSaxParser; do
>     mkdir -p $RPM_BUILD_ROOT%{_includedir}/$i
>     cp -a $i/include/* $RPM_BUILD_ROOT%{_includedir}/$i
> done
> 
> And then "manually" do Externals/MathMLSolver since that is a subdir of a
> subdir

I got it all in one by doing this:
for dir in  COLLADABaseUtils COLLADAFramework COLLADASaxFrameworkLoader \
             COLLADAStreamWriter COLLADAValidator Externals/MathMLSolver \
             GeneratedSaxParser; do
    mkdir -p %{buildroot}%{_includedir}/$(basename $dir)
    cp -a $dir/include/* %{buildroot}%{_includedir}/$(basename $dir)
done


> p.s.
> 
> One other thing, it might be good to also package the COLLADAValidator package
> in a -utils subpackage, as that may be a useful utility to have.

Done. While we on the subject of sub-packages. Should we also make a separate
-doc package?

Richard

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.