[Bug 682666] Review Request: DeTex - A program to remove TeX constructs from a text file

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682666

--- Comment #6 from Ankur Sinha <sanjay.ankur at gmail.com> 2011-04-28 05:11:58 EDT ---
AH! Sorry, I missed out on the earlier mail.

(In reply to comment #4)
> That looks good :)
> 
> According to the guidelines, patches in a .spec should have a comment. This
> concerns also fixes made through sed.

I'll add the comments.

> This will not (only) help the reviewer, but it help you as a maintainer.
> By the way, why these lines in %prep?
>    sed -i "/rm -f xxx\.l/d" Makefile
>    sed -i "s/mv lex\.yy\.c detex\.c/cp lex\.yy\.c detex\.c/" Makefile
> 

The above sed commands are to make some changes in the Makefile to enable
proper generation of debuginfo. If these files are removed/moved, debuginfo
generation fails. 

> In %description, use « DeTeX » instead of « Detex ». This seems to be the «
> official » name of the application.

Okay. 

Do I upload a new spec? Or can I make these changes before the scm commit
please? (Since only comments etc. are required)

Thanks,
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.