[Bug 524992] Review Request: toppler - platform game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524992

--- Comment #16 from Hans de Goede <hdegoede at redhat.com> 2011-04-28 15:01:35 EDT ---
Created attachment 495638
  --> https://bugzilla.redhat.com/attachment.cgi?id=495638
Patch for proper shared highscore file rights handling

Hi,

First of all apologies for taking for ever to get around to this. If you take
the attached patch, and drop the following 2 (which it obsoletes):
toppler-1.1.3-create_hiscores_file.patch
toppler-1.1.3-fix_highscore_lockfile_creation.patch

Then the dropping of sgid games handling is handled properly, further you
should also create (just a "touch" is enough) /var/games/toppler/toppler.hsc in
the spec file and include it with the proper rights / owner. Otherwise it will
get created with the first user starting toppler as owner which is not what we
want.

While working on this I also noticed the use of strncpy in highscore.cc strncpy
is evil as it does not guarantee 0 termination. So I've also done a patch to
replace it with snprintf, I'll attach that next.

If you can do a new version with these patches integrated, then I'll aprove
this package.

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.