[Bug 700537] Review Request: eclipse-mylyn-builds - Eclipse Mylyn Builds

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700537

--- Comment #3 from Andrew Overholt <overholt at redhat.com> 2011-04-28 16:27:43 EDT ---
(In reply to comment #2)
> (In reply to comment #1)
> > 1. why is ws-jaxme a BR but not an R?
> 
> It is a requirement for eclipse-mylyn-builds-hudson (only).

Sorry, I missed that.

> > 3. please include a link to a .spec that matches that which was used to create
> > the SRPM
> 
> New SRPM:
> http://fedorapeople.org/~jerboaa/rpm/mylyn/eclipse-mylyn-builds-3.5.1-1.fc15.src.rpm
> Updated spec file:
> http://fedorapeople.org/~jerboaa/rpm/mylyn/eclipse-mylyn-builds.spec

Great, the .spec files match and contain all necessary changes.

> > 4. have you run the patch by upstream (the 1.6 part)?
> 
> Initially, they had used some non Glassfish specific code, but that didn't work
> on java 5. See Eclipse bug 325176. I commented on the bug regarding our issue,
> but I don't think it's applicable for upstream.

Thanks for referencing the bug.  For those playing along at home, Severin will
be opening a bug to request that upstream's solution works for non-Glassfish
implementations of this class.  In the meantime, this patch is fine by me.

> I've also updated to 3.5.1.

Great, and I see you updated the qualifier, too, which is perfect.

The only remaining nit I have is "s/eclips/eclipse/g" :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.