[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=698576

Hans de Goede <hdegoede at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #2 from Hans de Goede <hdegoede at redhat.com> 2011-04-29 09:00:10 EDT ---
Full review done, results:

Good:
=====
- rpmlint checks return:
pal.src: W: spelling-error %description -l en_US gcal -> gal, cal, goal
pal.x86_64: W: spelling-error %description -l en_US gcal -> gal, cal, goal
 These can be ignored
- package meets naming guidelines
- package meets packaging guidelines
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- locales handled properly
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Needs work:
===========
- rpmlint checks return:
pal-debuginfo.x86_64: E: empty-debuginfo-package
 This is caused by the Makefile stripping the binary directly after the build,
 you can stop it from doing this by passing DEBUG=1 on the make cmdline.

- The license should be GPLv2+

- Fedora has a standard url for sf.net downloads, please use:
Source0:    http://downloads.sourceforge.net/palcal/pal-%{version}.tgz

- No need to pass: " -n %{name}-%{version}" to %setup, this is the default

- The preferred form for %defattr in fedora is:
%defattr(-,root,root,-)

- The files under %{_datadir}/doc/pal-%{version} should be marked as %doc,
  not gzipped and not include INSTALL. The easiest way is to add the following
  line to %files:
%doc doc/example.css COPYING ChangeLog
  Note traditionally this lines comes directly after the %defattr line

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.