[Bug 697673] Review Request: sjinn - Simple tool for sending & receiving data from RS-232 devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=697673

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #5 from Martin Gieseking <martin.gieseking at uos.de> 2011-04-29 10:34:37 EDT ---
Have the patches been sent upstream? Please also add comments about what the
patches do.
http://fedoraproject.org/wiki/PackagingGuidelines#All_patches_should_have_an_upstream_bug_link_or_comment


Please don't add the compressed manpage coming with the tarball. Decompress it
in %prep and let rpmbuild choose the compression format. 
Also, decompress the example scripts and add the "scripts" folder with %doc.


Use the plain sed command instead of the macro:
http://fedoraproject.org/wiki/PackagingGuidelines#Macros


%{?_smp_mflags} and the definition of CFLAGS are not required in "make
install".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.