[Bug 700862] Review Request: wmcalc - Calculator in a WindowMaker dockapp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700862

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de> 2011-04-29 13:22:14 EDT ---
(In reply to comment #0)
> Well, it builds, but the debug package is still useless
> (debuginfo-without-sources). I've applied the variable CFLAGS="$RPM_OPT_FLAGS"
> to the "make" call, but without success.

As you can see in the Makefile, CFLAGS is not used but FLAGS is. So just
replace the variable and the %optflags should be applied.

If you want to add the configuration file with %doc, remove the leading dot as
there shouldn't be any hidden doc files.

BTW, there is a memory issue in the application (array index out of bounds)
that might lead to a segfault on some systems. The number 11 should be replaced
with DISPSIZE in lines 117 and 118 of file wmcalc.c. If the upstream project is
dead, you might want to add a corresponding patch yourself.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.