[Bug 700833] Review Request: colorgcc - Script to colorize the terminal output of gcc, g++, cc, c++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700833

Hans de Goede <hdegoede at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #3 from Hans de Goede <hdegoede at redhat.com> 2011-04-30 04:43:26 EDT ---
Full review done:

Good:
=====
- rpmlint checks return:
colorgcc.src: W: no-%build-section
colorgcc.noarch: W: no-documentation
colorgcc.noarch: W: no-manual-page-for-binary color-g++
colorgcc.noarch: W: no-manual-page-for-binary color-cc
colorgcc.noarch: W: no-manual-page-for-binary color-gcc
colorgcc.noarch: W: no-manual-page-for-binary color-c++
 These can all be ignored
- package meets naming guidelines
- package meets packaging guidelines
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Needs work:
-----------
- Please use the full URL for Source0

- The license tag should be GPL+, per:
  http://fedoraproject.org/wiki/Licensing
  See the GPL (no version) table

- If you're not adding a %clean, nor cleaning the buildroot in %install, you
should not specify a buildroot at all, so drop:
BuildRoot:  %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

- A bitter way to handle %prep would be:
%prep
%setup -q -c -T
cp -p %{SOURCE0} .
%patch0 -p1
  You can then also drop the "cd %{name}-%{version}" from %install

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.