[Bug 701031] Review Request: zeitgeist-datahub - The zeitgeist engine data logger

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701031

Mario Blättermann <mariobl at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mariobl at freenet.de

--- Comment #1 from Mario Blättermann <mariobl at freenet.de> 2011-04-30 11:18:35 EDT ---
Please use macros consistently and as many as possible, as follows:

URL:  https://launchpad.net/%{name}
Source0:
http://launchpad.net/%{name}/0.7/%{version}/+download/%{name}-%{version}.tar.gz

%{_bindir}/%{name}
%{_mandir}/man1/%{name}.*
%{_sysconfdir}/xdg/autostart/%{name}.desktop

It's not needed to provide a https link to the homepage, http also works and
leads to the https page anyway.

The ChangeLog is empty, should be dropped from %docs.

Please add a period after the description.

You have to drop glib2-devel and gettext from BuildRequires. They are recursive
dependencies of gtk2-devel and intltool, respectively.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.