[Bug 608319] Review Request: memaker - An avatar creator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=608319

Mario Blättermann <mariobl at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mariobl at freenet.de

--- Comment #7 from Mario Blättermann <mariobl at freenet.de> 2011-04-30 16:35:35 EDT ---
$ rpmlint -v *
memaker.noarch: I: checking
memaker.noarch: I: checking-url https://launchpad.net/memaker (timeout 10
seconds)
memaker.noarch: W: hidden-file-or-dir
/usr/share/memaker/themes/glyphFace/Nose/..svg
memaker.noarch: W: no-manual-page-for-binary memaker
memaker.src: I: checking
memaker.src: I: checking-url https://launchpad.net/memaker (timeout 10 seconds)
memaker.src: W: invalid-url Source0: memaker-20100110-bzr.tar.gz
memaker.spec: W: invalid-url Source0: memaker-20100110-bzr.tar.gz
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

The mentioned hidden file isn't hidden really. It is the filename ~.svg, which
is erroneously recognized as hidden.

Please replace all occurences of the application name in the spec with %{name}.

Wouldn't it be better to use the "install" command instead of cp, especially to
keep timestamps?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.