[Bug 707617] Review Request: libircclient-qt - Cross-platform IRC client library written with Qt 4

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=707617

--- Comment #2 from Jan Kaluža <jkaluza at redhat.com> 2011-08-03 03:28:00 EDT ---
Thanks for taking this.

Spec URL: http://jkaluza.fedorapeople.org/libircclient-qt.spec
SRPM: http://jkaluza.fedorapeople.org/libircclient-qt-0.5.0-2.fc15.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3248944

(In reply to comment #1)
> * "spectool -g libircclient-qt.spec" fails downloading the tarball.

Should be fixed now.

> As long as we keep filling this Group tag, the correct group for library -devel
> packages is:  Development/Libraries

Fixed too.

> Repeating License and URL tags here is not needed. So, unless you insist on
> maintaining them in two places, better delete them here.

Fixed.

> %{?_isa} is missing:

Fixed.

> > %{_includedir}/ircclient-qt/Irc

This directory is now owned by libircclient-qt

> > %{_libdir}/qt4/mkspecs/features/libircclient-qt-config.prf
> > %{_libdir}/qt4/mkspecs/features/libircclient-qt.prf

Those are owned by qt-devel. I've added qt-devel as Requires for -devel
package.

> Also, since several essential headers, such as "irc.h" include Qt headers,
> there's a "Requires: qt-devel" missing in the -devel package.

Fixed.

> These %doc files are duplicates of the ones installed by the base package.

Removed from -devel.

> * What about packaging the 'doc' directory with its HTML documentation?

Added.

> * Build log warns about deprecated features being enabled and adds many
> warnings about individual deprecated items. What's the story here? The
> 'INSTALL' file comments on that, but doesn't answer when the "deprecated
> backwards compatible functionality" could be needed.

During make, moc_FILENAME.cpp meta files are created by Qt, which does some
magic to make Qt signals working (generates unique signals signatures and so
on). This meta files also contain signals handlers, so the signals are called
there. If some signals are deprecated, it will trigger that warning. This could
be fixed by disabling deprecated signals completely, but I think this should be
done by upstream first.

> 
> * Build log: compilation is non-verbose. One cannot see the used compiler
> flags, for example. This is because the QMake project file adds CONFIG +=
> silent.

I'm commenting that line using sed now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.