[Bug 723703] Review Request: eclipse-gprof - Eclipse plug-ins for gprof support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=723703

--- Comment #5 from sami <swagiaal at redhat.com> 2011-08-03 14:55:53 EDT ---
(In reply to comment #4)

> > [!]  Package does NOT have a %clean section which contains rm -rf %{buildroot}
> > (or $RPM_BUILD_ROOT). (not needed anymore)
> > please remove %{__rm} -rf %{buildroot}
> >
> 
> The package no longer has a %clean section.  There is an rm -rf buildroot at the
> start of the %install section.  Are you claiming this has to be removed as well?
> 

Yes, it is not needed. The buildroot will be cleaned automatically before
%install

> > [!]  Package contains code, or permissable content.
> > See comment above about non-gprof code
> >
> 
> The source tarball uses an upstream tarball from git based on a particular
> commit hash.  Optionally this could be trimmed via an external script, but there
> is no content that needs to be removed for the build to occur.  If it is
> recommended that the tarball be smaller at the cost of having it fetchable
> upstream, I will concur.
> 

It is preferable that the tarball contain no unrelated code.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.