[Bug 727879] Review Request: rubygem-rubyzip - A ruby module for reading and writing zip files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=727879

--- Comment #3 from Chris Lalancette <clalance at redhat.com> 2011-08-03 15:57:00 EDT ---
(In reply to comment #2)
> [+] MUST: rpmlint must be run on every package
> 44 rpmlint warnings from rdoc being derpy, that's not your fault though.
> [+] MUST: The package must be named according to the Package Naming 
>          Guidelines
> [+] MUST: The spec file name must match the base package %{name} [...]
> [+] MUST: The package must meet the Packaging Guidelines
> [+] MUST: The package must be licensed with a Fedora approved license
>          and meet the Licensing Guidelines
> Ruby license dual licenses with GPL, you may just want to note that in the
> specfile
> > http://fedoraproject.org/wiki/Licensing:Main mentions that it's only GPL compatible if it's dual licensed, I don't see how it hurts to make that explicit.

Ah, right.  I didn't read the Ruby license closely enough.  I'll change that
before importing the package.

Thanks for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.