[Bug 721179] Review Request: rubygem-extlib - Support library for DataMapper and Merb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721179

--- Comment #23 from Shawn Starr <shawn.starr at rogers.com> 2011-08-03 21:18:58 EDT ---
Points addressed, removed non-ruby dependency/package, merge %changelog

See updates spec:

Spec URL: http://www.sh0n.net/spstarr/fedora/rubygem-extlib/rubygem-extlib.spec
SRPM URL:
http://www.sh0n.net/spstarr/fedora/rubygem-extlib/rubygem-extlib-0.9.13-1.fc17.src.rpm

Now tracking rawhide (fedora 17)


1) The test suite is not executed at all. I would suggest to execute the test
suite using spec instead of rake. That would allow to remove the patch.

-- FIXED

2) The YARD documentation is generated in %check section. That is not correct
place.

- FIXED, RSpec 2.x is generating yard doc automagically now.

3) I would suggest to not provide the ruby subpackage unless there is real need
for it.

- FIXED, removed this

4) If that is .spec file recycled from EPEL, I would expect to see there the
original changelog.

- FIXED, merged %changelog

5) The BuildRoot is not necessary unless the spec is used to build EPEL5. In
that case I would suggest to put there some condition to be clear.

- FIXED, keep incase EPEL wants to use this spec file.

6) defattr in files section is not necessary anymore

- FIXED, removed

7) %clean section is not required

- FIXED, removed

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.