[Bug 727780] Review Request: qtruby - Ruby bindings for QT4

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=727780

--- Comment #2 from Ngo Than <than at redhat.com> 2011-08-04 06:43:27 EDT ---
(In reply to comment #1)
> Name: ? shouldn't we name it according ruby package naming scheme ruby-qt [1]
it's not in packaging guideline, i think it's better to follow the upstream
name scheme

> Summary: ok just s/QT4/Qt 4
> License: invalid-license LGPLv2.1+
> Group: ok
> URL: ok
> Sources: ok (md5sum d17198b985f954cedd92ab669623de59)
> BuildRoot: ok
> Requires/BuildRequires: not ok according to Ruby packaging guideline (no ABI
> specified) etc.
fixed

> Provides/Obsoletes: not ok, non sense to obsolete/provide same package (as it
> was in kdebindings subpackage already)
we need it for upgrade process.

> Description: ok
> Devel package: ok (but same prov/obs)
> Macros usage: ok, consistent
> ldconfig: ok
> Other Ruby requirements: ok
> Docs: ok
> 

> qtruby.src: W: invalid-license LGPLv2.1+
fixed

> qtruby.src: E: specfile-error sh: ruby: command not found
> qtruby.src: E: specfile-error sh: ruby: command not found
> 1 packages and 0 specfiles checked; 2 errors, 1 warnings.

it's rpmlint bug

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.