[Bug 728207] Review request: retrace-client - Client application for Retrace server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728207

Miroslav Lichvar <mlichvar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Miroslav Lichvar <mlichvar at redhat.com> 2011-08-04 10:33:33 EDT ---
Everything looks good, approved.

- rpmlint is silent
- package is named according to the Package Naming Guidelines
- the spec file name must matches the base package %{name}
- the package meets the Packaging Guidelines
- the package is licensed with a Fedora approved license and meets the
Licensing Guidelines (GPLv2+)
- the License field in the package spec file matches the actual license
- file containing the text of the license(s) for the package is included in
%doc
- the spec file is written in American English
- the spec file for the package is be legible
- the source used to build the package matches the upstream source, as provided
in the spec URL
  (18eb70e8283b698455b0592c6557722c  retrace-client-1.0.tar.gz)
- the package successfully compiles and builds into binary rpms on at least one
primary architecture
- all build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of the Packaging Guidelines
- the spec file handles locales properly
- the package doesn't bundle copies of system libraries
- the package owns all directories that it creates or depends on packages that
provide them
- the package does not list a file more than once in the spec file's %files
listings
- permissions on files are set properly
- the package consistently uses macros
- the package contains code, or permissable content
- all filenames in rpm packages are valid UTF-8

- the package builds in mock
- the package functions as described
- the package contains man pages for binaries/scripts

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.