[Bug 714326] Review Request: libtpcmisc - Miscellaneous PET functions

bugzilla at redhat.com bugzilla at redhat.com
Fri Aug 5 14:16:43 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714326

Richard Shaw <hobbes1069 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #8 from Richard Shaw <hobbes1069 at gmail.com> 2011-08-05 10:16:42 EDT ---
Ok, everything looks good. I noticed that upstream has gone to version 1.4.9.
Probably wouldn't be a bad idea to update your package before checking it in.

+: OK
-: must be fixed
=: should be fixed (at your discretion)
?: Question or clairification needed
N: not applicable

MUST:
[+] rpmlint output: shown in comment: No unexpected output
[+] follows package naming guidelines
[+] spec file base name matches package name
[+] package meets the packaging guidelines
[+] package uses a Fedora approved license: LGPLv2+
[+] license field matches the actual license.
[N] license file is included in %doc:
[+] spec file is in American English
[+] spec file is legible
[+] sources match upstream: md5sums match: a64787a2a98ec8d7dded6af9c5fc82a8
[+] package builds on at least one primary arch: Tested F14/F15
[N] appropriate use of ExcludeArch
[+] all build requirements in BuildRequires
[N] spec file handles locales properly
[N] ldconfig in %post and %postun
[+] no bundled copies of system libraries
[N] no relocatable packages
[N] package owns all directories that it creates
[+] no files listed twice in %files
[+] proper permissions on files
[+] consistent use of macros
[+] code or permissible content
[N] large documentation in -doc
[+] no runtime dependencies in %doc
[+] header files in -devel
[+] static libraries in -static: In -devel with -statis Provides
[+] .so in -devel
[+] -devel requires main package
[+] package contains no libtool archives
[N] package contains a desktop file, uses desktop-file-install/validate
[+] package does not own files/dirs owned by other packages
[+] all filenames in UTF-8

SHOULD:
[N] query upstream for license text
[N] description and summary contains available translations
[+] package builds in mock
[+] package builds on all supported arches
[?] package functions as described: Did not test.
[+] sane scriptlets
[N] subpackages require the main package (other than -devel)
[N] placement of pkgconfig files
[N] file dependencies versus package dependencies
[=] package contains man pages for binaries/scripts:

*** APPROVED ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list