[Bug 723326] Review Request: dolibarr - ERP & CRM for small companies, freelances or foundations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=723326

--- Comment #2 from Remi Collet <fedora at famillecollet.com> 2011-08-06 08:22:02 EDT ---
First comments

Don't define name, version, release (Name, Version and Release directives are
enough)

Release must include %{?dist}

For readilibilty clean the spec of all non-fedora stuff

Requiring mysql-server is probably a bad idea (you can install the web-app on a
server and the DB on another)


Most stuff in %post should go to %install (and %file)
Most stuff in %postun should be obsoleted by previous comment


Don't create /usr/share/doc/dolibar.
Use %doc <pathinsourcetree>
File will be added to /usr/share/doc/dolibar-3.1.0 which is the standard
default location.

Lang file must be tag as lang file.

You must not bundle library (artichow, tcpdf, ..) but use system ones (and
submit new packages if not available).

Use desktop-file-install to install .desktop (not install)

Please confirm the requires PHP extensions / version required (phpci reports
php 5.3.0 and lot extensions, probably some "false/positive" due to embedded
libraries)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.