[Bug 716697] Review Request: perl-FusionInventory-Agent-Task-ESX - vCenter/ESX/ESXi remote inventory for FusionInventory Agent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716697

Haïkel Guémar <karlthered at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #2 from Haïkel Guémar <karlthered at gmail.com> 2011-08-07 09:40:27 EDT ---
perl-FusionInventory-Agent-Task-ESX (Perl package)

MUST: rpmlint must be run on src.rpm and rpm.  OK
$ rpmlint perl-FusionInventory-Agent-Task-ESX-1.1.2-1.fc17.src.rpm         
perl-FusionInventory-Agent-Task-ESX.src: W: spelling-error Summary(en_US)
vCenter -> v Center, center, cementer
perl-FusionInventory-Agent-Task-ESX.src: W: summary-not-capitalized C
vCenter/ESX/ESXi remote inventory for FusionInventory Agent
perl-FusionInventory-Agent-Task-ESX.src: W: spelling-error %description -l
en_US vCenter -> v Center, center, cementer
perl-FusionInventory-Agent-Task-ESX.src: W: spelling-error %description -l
en_US ocsinventory -> inventory
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

$ rpmlint -iv perl-FusionInventory-Agent-Task-ESX-1.1.2-1.fc17.noarch.rpm      
                                                                               
 (0)
perl-FusionInventory-Agent-Task-ESX.noarch: I: checking
perl-FusionInventory-Agent-Task-ESX.noarch: W: spelling-error Summary(en_US)
vCenter -> v Center, center, cementer
The value of this tag appears to be misspelled. Please double-check.

perl-FusionInventory-Agent-Task-ESX.noarch: W: summary-not-capitalized C
vCenter/ESX/ESXi remote inventory for FusionInventory Agent
Summary doesn't begin with a capital letter.

perl-FusionInventory-Agent-Task-ESX.noarch: W: spelling-error %description -l
en_US vCenter -> v Center, center, cementer
The value of this tag appears to be misspelled. Please double-check.

perl-FusionInventory-Agent-Task-ESX.noarch: W: spelling-error %description -l
en_US ocsinventory -> inventory
The value of this tag appears to be misspelled. Please double-check.

perl-FusionInventory-Agent-Task-ESX.noarch: I: checking-url
http://forge.fusioninventory.org/projects/fusioninventory-agent-task-esx
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

The non-capitalized summary is ok, since it would alter the proper spelling of
vCenter.

MUST: package named accordingly to package naming guidelines. OK 

MUST: spec file name match %{name}  OK

MUST: package meets packaging guidelines OK

MUST: package must be licensed under a fedora-compliant license OK (GPLv2+)

MUST: License field in package spec match actual license OK
License file included and distributed

MUST: spec in legible american english OK

MUST: sources provided match upstream's OK

provided sources sha1sum: dc5b24fe1e9f0f7d288448cc34435363a42566f9
upstream sources sha1sum: dc5b24fe1e9f0f7d288448cc34435363a42566f9

MUST: package successfully compiles on at least one primary architecture OK
(all of them)

MUST: all build dependencies are listed in BR KO

MUST: package must own all directories it creates OK

MUST: package does not list a file more than once in %files section OK

MUST: permissions are properly set OK

MUST: package consistenly use macros OK

MUST: package contains permissable content OK

MUST: package does not own directories owned by other packages OK

MUST: all filenames in package are valid UTF-8 OK

SHOULD: mock builds were done on rawhide on all primary architectures
(x86/x86_64) KO
tests fail due to missing BR: perl(LWP::Protocol::https)
I added it and mock builds went fine

SHOULD: man pages are provided OK

This package respects general & Perl Fedora Packaging guidelines, as soon as
the missing BR will be added, it will be approved

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.