[Bug 716698] Review Request: perl-FusionInventory-Agent-Task-NetDiscovery - Network discovery support for FusionInventory Agent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=716698

Haïkel Guémar <karlthered at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |karlthered at gmail.com
         AssignedTo|nobody at fedoraproject.org    |karlthered at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Haïkel Guémar <karlthered at gmail.com> 2011-08-07 09:52:32 EDT ---
quite a trivial review

perl-FusionInventory-Agent-Task-NetDiscovery (Perl package)

MUST: rpmlint must be run on src.rpm and rpm.  OK
$ rpmlint -iv perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc17.src.rpm  
perl-FusionInventory-Agent-Task-NetDiscovery.src: I: checking
perl-FusionInventory-Agent-Task-NetDiscovery.src: I: checking-url
http://forge.fusioninventory.org/projects/fusioninventory-agent-task-netdiscovery
(timeout 10 seconds)
perl-FusionInventory-Agent-Task-NetDiscovery.src: I: checking-url
http://search.cpan.org/CPAN/authors/id/F/FU/FUSINV/FusionInventory-Agent-Task-NetDiscovery-1.5.tar.gz
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -iv
perl-FusionInventory-Agent-Task-NetDiscovery-1.5-2.fc17.noarch.rpm
perl-FusionInventory-Agent-Task-NetDiscovery.noarch: I: checking
perl-FusionInventory-Agent-Task-NetDiscovery.noarch: I: checking-url
http://forge.fusioninventory.org/projects/fusioninventory-agent-task-netdiscovery
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

MUST: package named accordingly to package naming guidelines. OK 

MUST: spec file name match %{name}  OK

MUST: package meets packaging guidelines OK

MUST: package must be licensed under a fedora-compliant license OK (GPLv2+)

MUST: License field in package spec match actual license OK
License file included and distributed

MUST: spec in legible american english OK

MUST: sources provided match upstream's OK

provided sources sha1sum: e66c6bcdb77f8a4b8f9cc0927dc247dcb90b6888
upstream sources sha1sum: e66c6bcdb77f8a4b8f9cc0927dc247dcb90b6888

MUST: package successfully compiles on at least one primary architecture OK
(all of them)

MUST: all build dependencies are listed in BR OK

MUST: package must own all directories it creates OK

MUST: package does not list a file more than once in %files section OK

MUST: permissions are properly set OK

MUST: package consistenly use macros OK

MUST: package contains permissable content OK

MUST: package does not own directories owned by other packages OK

MUST: all filenames in package are valid UTF-8 OK

SHOULD: mock builds were done on rawhide on all primary architectures
(x86/x86_64) OK


SHOULD: man pages are provided OK

This package respects general & Perl Fedora Packaging guidelines, so i hereby
approve this package into Fedora Packages Collection

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.