[Bug 714328] Review Request: xmedcon - A medical image conversion utility and library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=714328

Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tcallawa at redhat.com

--- Comment #1 from Tom "spot" Callaway <tcallawa at redhat.com> 2011-08-08 13:53:13 EDT ---
I'll take a pass at this. One obvious fix:

Instead of doing:

%ifarch x86_64
    sed -i \
           -e  "s|tpc_prefix/lib|tpc_prefix/lib64|" \
           -e  "s|nifti_prefix/lib|nifti_prefix/lib64|" configure
%endif

Just do:

sed -i \
       -e  "s|tpc_prefix/lib|tpc_prefix/%{_lib}|" \
       -e  "s|nifti_prefix/lib|nifti_prefix/%{_lib}|" configure

Also, I could not get this code to build at all, because of errors like this:

/usr/bin/ld: /usr/lib64/libtpcimgio.a(ecat7w.o): relocation R_X86_64_32 against
`.rodata.str1.1' can not be used when making a shared object; recompile with
-fPIC
/usr/lib64/libtpcimgio.a: could not read symbols: Bad value

Sure enough, the libtpcimgio and libtpcmisc packages only spits out non-PIC
static libs. Which is fine if you never need to make a shared object from them
later, but we definitely do in xmedcon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.