[Bug 727543] jnr-ffi - Java Abstracted Foreign Function Layer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=727543

--- Comment #2 from Alexander Kurtakov <akurtako at redhat.com> 2011-08-09 02:17:42 EDT ---
Few initial problems:
* License is wrong - ASL 2.0 in the source but LGPLv3 in the spec
* rm -rf $RPM_BUILD_ROOT as first line of install section is no longer needed
* clean section is no longer needed
* versioned jars are installed, please install only unversioned one
http://fedoraproject.org/wiki/Packaging:Java#Filenames
* %defattr(-,root,root,-) are no longer needed
* do not install versioned javadoc folder
http://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
* post/postun %update_maven_depmap are no longer needed
* %add_to_maven_depmap is used but it's deprecated now please use
%add_maven_depmap JPP-%{name}.pom %{name}.jar quite simple and validates you're
doing the right thing
* Do not BuildRequires: ant-nodeps it has been merged into main ant package

Question:
* Do we need the changelog from jaffl at all? For me it only makes the spec
bigger but it's up to you

Once the listed problems are fixed I'll do the formal review

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.