[Bug 726210] Review Request: freewrl - X3D / VRML visualization program

Tue Aug 9 06:15:30 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=726210

--- Comment #2 from Tim Lauridsen <tla at rasmil.dk> 2011-08-09 02:15:29 EDT ---

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

[x] : MUST - Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x] : MUST - Fully versioned dependency in subpackages, if present.
[x] : MUST - Header files in -devel subpackage, if present.
[x] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
[x] : MUST - ldconfig called in %post and %postun if required.
[x] : MUST - Package does not contain any libtool archives (.la)
[x] : MUST - Package use %makeinstall only when make install DESTDIR=...
doesn't work.
[x] : MUST - Package is named according to the Package Naming Guidelines.
[x] : MUST - Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-] : MUST - %config files are marked noreplace or the reason is justified.
[-] : MUST - The spec file handles locales properly.
[-] : MUST - No %config files under /usr.
[-] : MUST - Static libraries in -static subpackage, if present.
[!] : MUST - Rpmlint output is silent.

        rpmlint freewrl-java-1.22.12-0.1.pre2.fc17.i686.rpm

================================================================================
        freewrl-java.i686: W: only-non-binary-in-usr-lib
        1 packages and 0 specfiles checked; 0 errors, 1 warnings.

================================================================================

        rpmlint libEAI-1.22.12-0.1.pre2.fc17.i686.rpm

================================================================================
        libEAI.i686: W: shared-lib-calls-exit /usr/lib/libFreeWRLEAI.so.1.22.12
exit at GLIBC_2.0
        1 packages and 0 specfiles checked; 0 errors, 1 warnings.

================================================================================

        rpmlint freewrl-1.22.12-0.1.pre2.fc17.src.rpm

================================================================================
        freewrl.src:120: E: hardcoded-library-path in
/usr/lib/jvm/java-openjdk/jre/lib/ext/vrml.jar
        1 packages and 0 specfiles checked; 1 errors, 0 warnings.

================================================================================

        rpmlint freewrl-debuginfo-1.22.12-0.1.pre2.fc17.i686.rpm

================================================================================
        1 packages and 0 specfiles checked; 0 errors, 0 warnings.

================================================================================

        rpmlint freewrl-devel-1.22.12-0.1.pre2.fc17.i686.rpm

================================================================================
        1 packages and 0 specfiles checked; 0 errors, 0 warnings.

================================================================================

        rpmlint libEAI-devel-1.22.12-0.1.pre2.fc17.i686.rpm

================================================================================
        libEAI-devel.i686: W: no-documentation
        1 packages and 0 specfiles checked; 0 errors, 1 warnings.

================================================================================

        rpmlint freewrl-1.22.12-0.1.pre2.fc17.i686.rpm

================================================================================
        freewrl.i686: W: no-manual-page-for-binary freewrl_msg
        freewrl.i686: W: no-manual-page-for-binary freewrl_snd
        1 packages and 0 specfiles checked; 0 errors, 2 warnings.

================================================================================

[!] : MUST - Development .so files in -devel subpackage, if present.
        freewrl-1.22.12-0.1.pre2.fc17.i686.rpm :
/usr/lib/mozilla/plugins/libFreeWRLplugin.so

[!] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
        /home/tim/tmp/reviewhelper/726210/freewrl-1.22.12_pre2.tar.bz2 :
          MD5SUM this package     : e9baa64e551483dbfcb21e879fdf0d8e
          MD5SUM upstream package : 7530cf536beade1cfbc4400c5725818d
        README.FreeWRL.java :
          MD5SUM this package     : e56065d5fc275961e6058540786d05fd
          MD5SUM upstream package : upstream source not found

[x] : MUST - Package is licensed with an open-source compatible license and
meets other legal requirements as defined in the legal section of Packaging
Guidelines.
[x] : MUST - %build honors applicable compiler flags or justifies otherwise.
[x] : MUST - All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x] : MUST - Package contains no bundled libraries.
[x] : MUST - Changelog in prescribed format.
[x] : MUST - Sources contain only permissible code or content.
[x] : MUST - Macros in Summary, %description expandable at SRPM build time.
[x] : MUST - Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application.
[x] : MUST - Package requires other packages for directories it uses.
[x] : MUST - Package uses nothing in %doc for runtime.
[x] : MUST - Package is not known to require ExcludeArch.
[x] : MUST - Permissions on files are set properly.
[x] : MUST - Package does not contain duplicates in %files.
[x] : MUST - Large documentation files are in a -doc subpackage, if required.
[x] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x] : MUST - License field in the package spec file matches the actual license.
[!] : MUST - License file installed when any subpackage combination is
installed.
    libEAI subpackage don't require main package, so license file is not pulled
in.
[x] : MUST - Package consistently uses macros. instead of hard-coded directory
names.
[x] : MUST - Package meets the Packaging Guidelines.
[x] : MUST - Package does not generates any conflict.
[x] : MUST - Package does not contains kernel modules.
[x] : MUST - Package contains no static executables.
[x] : MUST - Package obeys FHS, except libexecdir and /usr/target.
[x] : MUST - Package must own all directories that it creates.
[x] : MUST - Package does not own files or directories owned by other packages.
[x] : MUST - Package installs properly.
[x] : MUST - Rpath absent or only used for internal libs.
[x] : MUST - Package is not relocatable.
[x] : MUST - Requires correct, justified where necessary.
[x] : MUST - Spec file is legible and written in American English.
[-] : MUST - Package contains a SysV-style init script if in need of one.
[x] : MUST - File names are valid UTF-8.
[x] : MUST - Useful -debuginfo package or justification otherwise.
[x] : SHOULD - Reviewer should test that the package builds in mock.
[x] : SHOULD - Dist tag is present.
[x] : SHOULD - The placement of pkgconfig(.pc) files are correct.
[x] : SHOULD - SourceX is a working URL.
[x] : SHOULD - Spec use %global instead of %define.
[-] : SHOULD - Uses parallel make.
[!] : SHOULD - SourceX / PatchY prefixed with %{name}.
        Source1: README.FreeWRL.java (README.FreeWRL.java)

[-] : SHOULD - If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[x] : SHOULD - No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x] : SHOULD - Final provides and requires are sane (rpm -q --provides and rpm
-q --requires).
[?] : SHOULD - Package functions as described.
[x] : SHOULD - Latest version is packaged.
[x] : SHOULD - Package does not include license text files separate from
upstream.
[!] : SHOULD - Man pages included for all executables.
[-] : SHOULD - Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x] : SHOULD - Scriptlets must be sane, if used.
[!] : SHOULD - Description and summary sections in the package spec file
contains translations for supported Non-English languages, if available.
[x] : SHOULD - Package should compile and build into binary rpms on all
supported architectures.
[!] : SHOULD - %check is present and all tests pass.
[x] : SHOULD - Packages should try to preserve timestamps of original installed
files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.