[Bug 692069] Review Request: pps-tools - LinuxPPS user-space tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=692069

Ankur Sinha <sanjay.ankur at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Ankur Sinha <sanjay.ankur at gmail.com> 2011-08-09 13:08:54 EDT ---
Hello,

I was just wondering if it would be better to link it like this:

ln -s $RPM_BUILD_ROOT%{_includedir}/timepps.h $RPM_BUILD_ROOT%{_includedir}/sys

instead of 

ln -s ../timepps.h $RPM_BUILD_ROOT%{_includedir}/sys

The rest looks good!

[ankur at ankur SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm
pps-tools.i686: W: no-manual-page-for-binary ppsbind
pps-tools.i686: W: no-manual-page-for-binary ppswatch
pps-tools.i686: W: no-manual-page-for-binary ppsfind
pps-tools.i686: W: no-manual-page-for-binary ppstest
pps-tools.src: W: invalid-url Source0: pps-tools-20100413git74c32c.tar.gz
pps-tools-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/pps-tools/timepps.h
pps-tools-devel.i686: W: no-documentation
pps-tools-devel.i686: E: incorrect-fsf-address /usr/include/timepps.h
4 packages and 0 specfiles checked; 2 errors, 6 warnings.


Please do request upstream to correct the FSF address. 

XX APPROVED XX

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.