[Bug 529441] Review Request: pdfbox - Java PDF library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529441

--- Comment #17 from Alexander Kurtakov <akurtako at redhat.com> 2011-08-10 07:57:53 EDT ---
Comments:
* please update to 1.6.0
* if we don't need the depmap anymore drop it or fix the comment
* ant-nodeps is merged into ant please BR ant
* please use the new name apache-commons-logging not jakarta-commons-logging
* buildroot definition is not needed
* post/postun %update_maven_depmap are no longer needed
* rm -rf $RPM_BUILD_ROOT as install first line and the clean section are no
longer needed
* please use the new %add_maven_depmap JPP....pom ...jar instead of the old
%add_to_maven_depmap
* %defattr(-,root,root,-) are no longer needed
* installing NOTICE.txt README.txt RELEASE-NOTES.txt in main package only
should be enough
* I see 
downloadfile:
    [mkdir] Created dir:
/home/akurtakov/work/rpmeditor-demo/pdfbox/pdfbox-1.5.0/pdfbox/download
      [get] Getting:
http://repo2.maven.org/maven2/com/adobe/pdf/pcfi/2010.08.09/pcfi-2010.08.09.jar
      [get] To:
/home/akurtakov/work/rpmeditor-demo/pdfbox/pdfbox-1.5.0/pdfbox/download/pcfi-2010.08.09.jar
in the build log please either patch it out to not be downloaded or stop it in
some other way if not needed or whatever solution is best

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.