[Bug 728256] Review Request: rubygem-activesupport2.3 - rails 2 alongside rails 3

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728256

--- Comment #2 from Emanuel Rietveld <codehotter at gmail.com> 2011-08-10 09:58:57 EDT ---
Created attachment 517615
  --> https://bugzilla.redhat.com/attachment.cgi?id=517615
rpmlint output

Pushed new package to replace incorrect Rakefile version in .src.rpm.

Full rpmlint output (233 warnings) attached. There are many warnings related to
'unexpanded macro' which are actually escaped characters, like %3f, in the
filenames of the ri documentation. The previous version of the package,
activesupport-2.3.8 in F14, had these warnings as well.

$ rpmlint /var/lib/mock/fedora-15-x86_64/result/*.rpm | grep -v
unexpanded-macro

rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/MemCache/failover-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/MemCache/namespace-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/TZInfo/TimezonePeriod/end_transition-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/MemCache/logger-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/MemCache/timeout-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/MemCache/Server/host-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/MemCache/Server/retry-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/MemCache/no_reply-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/MemCache/Server/port-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/MemCache/multithread-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/MemCache/Server/weight-i.ri
rubygem-activesupport2.3.noarch: W: file-not-utf8
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/cache.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/MemCache/Server/status-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/TZInfo/TimezonePeriod/offset-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/TZInfo/TimezonePeriod/start_transition-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/MemCache/servers-i.ri
rubygem-activesupport2.3.noarch: W: wrong-file-end-of-line-encoding
/usr/lib/ruby/gems/1.8/doc/activesupport-2.3.12/ri/ActiveSupport/CoreExtensions/Numeric/Time/since-i.ri
rubygem-activesupport2.3.src: W: invalid-url Source2:
activesupport-23-tests.tgz
rubygem-activesupport2.3.src: W: file-size-mismatch Rakefile = 5371,
https://raw.github.com/rails/rails/v2.3.12/activesupport/Rakefile = 1
2 packages and 0 specfiles checked; 0 errors, 233 warnings.

If ignoring the unexpanded-macro warnings of the ri documentation, there are
several warnings left. First a list of 'wrong-file-end-of-line-encoding'. I am
reluctant to fix these, because stripping \r from actionpack files has been
known to break rails before - see comment of mmorsi in that spec file. Besides,
the files are not plain text files, but binary documentation files. It is
unclear what the effect of stripping \r characters out of a binary file will
be. Of course, I am open to a difference of opinion.

Next one, invalid-url, is to be expected. For some reason the tests are not
packaged in the upstream source gem, so the activesupport-23-tests.tgz source
is created from git. The procedure for reproducing activesupport-23-tests.tgz
is documented in the spec file.

Finally, however, I do not understand the file-size-mismatch at all.

curl -O https://raw.github.com/rails/rails/v2.3.12/activesupport/Rakefile
results in a file with size of 5371 which is in every respect identical to the
file in the source rpm. What is rpmlint complaining about here?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.