[Bug 727543] jnr-ffi - Java Abstracted Foreign Function Layer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=727543

--- Comment #4 from Mo Morsi <mmorsi at redhat.com> 2011-08-10 16:46:20 EDT ---
Updated spec URL: http://mo.morsi.org/files/jruby/jnr-ffi.spec
Updated SRPM URL: http://mo.morsi.org/files/jruby/jnr-ffi-0.5.10-2.fc14.src.rpm

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3264801

(In reply to comment #2)
> Few initial problems:
> * License is wrong - ASL 2.0 in the source but LGPLv3 in the spec

Project is dual licensed under the ASL and LGPLv3+, license field has been
updated to reflect this

> * rm -rf $RPM_BUILD_ROOT as first line of install section is no longer needed
> * clean section is no longer needed

Both are done

> * versioned jars are installed, please install only unversioned one
> http://fedoraproject.org/wiki/Packaging:Java#Filenames
> * %defattr(-,root,root,-) are no longer needed
> * do not install versioned javadoc folder
> http://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation

As are these three.

> * post/postun %update_maven_depmap are no longer needed

Done

> * %add_to_maven_depmap is used but it's deprecated now please use
> %add_maven_depmap JPP-%{name}.pom %{name}.jar quite simple and validates you're
> doing the right thing

When I change this I get the following error:

+ %add_maven_depmap JPP-jnr-ffi.pom jnr-ffi.jar
/var/tmp/rpm-tmp.Vqrru5: line 38: fg: no job control
error: Bad exit status from /var/tmp/rpm-tmp.Vqrru5 (%install)

Thoughts?


> * Do not BuildRequires: ant-nodeps it has been merged into main ant package
> 

Done


> Question:
> * Do we need the changelog from jaffl at all? For me it only makes the spec
> bigger but it's up to you
> 

Truncated these extra bits


(In reply to comment #3)
> Oh and I forgot to say please make the Obsoletes/Provides versioned

Done (believe I did this correctly though would like verification).

Thanks for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.