[Bug 724878] Review Request: TexStudio - A feature-rich editor for LaTeX documents

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=724878

--- Comment #11 from Martin Gieseking <martin.gieseking at uos.de> 2011-08-12 14:26:56 EDT ---
(In reply to comment #10)
> Ok thanks for the review! I asked upstream about the licensing [1] and the qt
> files [2]. So far I only received a reply for the qt_lang files and they are
> unmodified, so I removed them.

OK, sounds good. Please try to build the package and verify whether the Qt
locales, e.g. the German ones, are actually used, or if you get untranslated
English text snippets somewhere when running the application.

> The missing GPLv3 file is not a blocker or? Do I need to add one?

Nope. It's an upstream thing that should be considered in a future release.
There's no further action required on your side.


> Also I added the missing file_install macro but I am not sure if it's possible
> to use %exclude %{_datadir}/texstudio/texstudio_*.qm to exclude them in the
> file section.

Unfortunately, that's not possible. %exclude will also exclude the locale files
added by %files -f %{name}.lang. You have to give a list of path expressions
that select everything in %{_datadir}/texstudio/ except the .mq files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.