[Bug 675050] Review Request: hekafs - Cloud Filesystem

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675050

Chris Lalancette <clalance at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #31 from Chris Lalancette <clalance at redhat.com> 2011-08-12 14:40:24 EDT ---
A couple of nits:

1)  In recent fedora, the python_sitelib definition at the top is no longer
necessary, as RPM does it for you.
2)  There are a couple of stray pieces of whitespace at the ends of lines.  Not
a huge deal, but maybe nice to fix when you import.
3)  It would probably be a good idea to add a variable for the glusterfs
version (%global glusterfs_version 3.2.1), since you use it in multiple places.
4)  The comment talking about "release_version" at the top doesn't make much
sense, since it looks like release_version was removed at some point.

For the Obsoletes, I agree with your Comment #28; just remove it, since it
never shipped that way.

Otherwise it looks fine.  The nits above are all small enough that I'm
comfortable with approving, and just asking that you fix when you import.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.