[Bug 702957] Review Request: pclock - WindowMaker dockapp which displays an analog clock
bugzilla at redhat.com
bugzilla at redhat.com
Sun Aug 14 12:18:00 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=702957
--- Comment #7 from Iain Arnell <iarnell at gmail.com> 2011-08-14 08:17:58 EDT ---
pclock-demopath.diff needs to be updated to reference the unversioned
/usr/share/pclock directory.
Otherwise, it's another clean simple package. The rpmlint warnings can be
ignored, and there's not much you can reasonably do about the FSF address
"error" as upstream seems to have gone.
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3271907
Spec looks sane, clean and consistent; license is correct (GPLv2+).
Source tarballs match upstream (sha1sum):
212b8b6a05d76e70ff34fb3bd3e39ed991e2c7e1 pclock-0.13.1.tgz
212b8b6a05d76e70ff34fb3bd3e39ed991e2c7e1 pclock-0.13.1.tgz.srpm
Final provides / requires are sane:
======> pclock-0.13.1-2.fc17.src.rpm <======
====> rpmlint
pclock.src: I: enchant-dictionary-not-found de
pclock.src: W: strange-permission pclock-0.13.1.tgz 0755L
pclock.src:64: W: macro-in-%changelog %{_datadir}
pclock.src:64: W: macro-in-%changelog %{name}
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
====> spelling
pclock.src: W: spelling-error Summary(en_US) dockapp -> dock app, dock-app,
paddock
pclock.src: W: spelling-error %description -l en_US pixmap -> pix map, pix-map,
mapping
====> provides
====> requires
libXext-devel
libXpm-devel
====> obsoletes
====> conflicts
======> pclock-0.13.1-2.fc17.x86_64.rpm <======
====> rpmlint
pclock.x86_64: I: enchant-dictionary-not-found de
pclock.x86_64: E: incorrect-fsf-address /usr/share/doc/pclock-0.13.1/COPYING
pclock.x86_64: W: no-manual-page-for-binary pclock
1 packages and 0 specfiles checked; 1 errors, 1 warnings.
====> spelling
pclock.x86_64: W: spelling-error Summary(en_US) dockapp -> dock app, dock-app,
paddock
pclock.x86_64: W: spelling-error %description -l en_US pixmap -> pix map,
pix-map, mapping
====> provides
pclock = 0.13.1-2.fc17
pclock(x86-64) = 0.13.1-2.fc17
====> requires
/bin/sh
libc.so.6()(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libm.so.6()(64bit)
libm.so.6(GLIBC_2.2.5)(64bit)
libX11.so.6()(64bit)
libXext.so.6()(64bit)
libXpm.so.4()(64bit)
rtld(GNU_HASH)
====> obsoletes
====> conflicts
======> pclock-debuginfo-0.13.1-2.fc17.x86_64.rpm <======
====> rpmlint
pclock-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pclock-0.13.1/src/Main.c
pclock-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pclock-0.13.1/src/getopt.h
pclock-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pclock-0.13.1/src/Graphics.c
pclock-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pclock-0.13.1/src/PClock.h
1 packages and 0 specfiles checked; 4 errors, 0 warnings.
====> provides
pclock-debuginfo = 0.13.1-2.fc17
pclock-debuginfo(x86-64) = 0.13.1-2.fc17
====> requires
====> obsoletes
====> conflicts
====> mock install
INFO: mock.py version 1.1.12 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.12
INFO: Mock Version: 1.1.12
State Changed: lock buildroot
INFO: installing package(s): pclock-0.13.1-2.fc17.x86_64.rpm
pclock-debuginfo-0.13.1-2.fc17.x86_64.rpm
INFO: Ignored option -c (probably due to merging -yc != -y -c)
================================================================================
Package Arch Version Repository Size
================================================================================
Installing:
pclock x86_64 0.13.1-2.fc17 /pclock-0.13.1-2.fc17.x86_64 134 k
pclock-debuginfo x86_64 0.13.1-2.fc17 /pclock-debuginfo-0.13.1-2.fc17.x86_64
79 k
Installing for dependencies:
libX11 x86_64 1.4.4-1.fc17 fedora 581 k
libX11-common noarch 1.4.4-1.fc17 fedora 174 k
libXau x86_64 1.0.6-2.fc15 fedora 24 k
libXext x86_64 1.2.0-2.fc15 fedora 33 k
libXpm x86_64 3.5.8-3.fc15 fedora 58 k
libxcb x86_64 1.7-3.fc16 fedora 100 k
Transaction Summary
================================================================================
Install 8 Package(s)
Total size: 1.2 M
Installed size: 1.6 M
Installed:
pclock.x86_64 0:0.13.1-2.fc17 pclock-debuginfo.x86_64 0:0.13.1-2.fc17
Dependency Installed:
libX11.x86_64 0:1.4.4-1.fc17 libX11-common.noarch 0:1.4.4-1.fc17
libXau.x86_64 0:1.0.6-2.fc15 libXext.x86_64 0:1.2.0-2.fc15
libXpm.x86_64 0:3.5.8-3.fc15 libxcb.x86_64 0:1.7-3.fc16
State Changed: unlock buildroot
State Changed: end
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list