[Bug 697049] Review Request: sawfish-pager - A pager for the Sawfish window manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=697049

Peter Lemenkov <lemenkov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lemenkov at gmail.com

--- Comment #8 from Peter Lemenkov <lemenkov at gmail.com> 2011-08-14 12:22:04 EDT ---
(In reply to comment #7)
> > Please replace COPYING (includes the wrong FSF address) with a new one from the
> > GNU websites:
> 
> Spec done. Upstream notified.
> 
> > glib2-devel is a recursive dependency of gtk2-devel, you might drop it.
> 
> cairo-devel is too. I dropped both.

Just a side note. Rule of thumb for these situations is 

a) if your app explicitly uses files from both packages (say, your app's
sources are  including headers from both ones) then you *should* list both as
BuildRequires. The idea is that one of these packages could drop dependency on
another (which is very unlikely in case of GTK2, so you really can drop these
*-devel BuildRequires).
b) Otherwise you shouldn't require both packages (to shorted dependency chain
as little as possible).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.