[Bug 730570] Review Request: python-requests - Python HTTP library for Humans

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=730570

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review+

--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2011-08-14 17:56:06 EDT ---
Review:
- %files ok
- noarch ok
- BR/R ok
  (You could BR: python-setuptools, but don't need to)
- License ok
- scratch build ok:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=3272326

Needswork:
- in the description is a space too much before "cumbersome"
- noarch and OPT_FLAGS don't match together, please delete the OPT_FLAGS stuff
- rpmlint:
$ rpmlint ~/rpmbuild/RPMS/noarch/python-requests-0.5.1-1.fc15.noarch.rpm
~/rpmbuild/SRPMS/python-requests-0.5.1-1.fc15.src.rpm 
python-requests.src:1: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab:
line 1)
2 packages and 0 specfiles checked; 0 errors, 1 warnings.


Please fix the minor issues from above and this is:

##############################################################

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.