[Bug 730426] Review Request: mindless - Find the secret code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=730426

--- Comment #2 from Göran Uddeborg <goeran at uddeborg.se> 2011-08-15 12:49:48 EDT ---
Thanks very much for your comments!

> For the COPYING file, you should fetch a new one from fsf.org

Seems I read
http://lists.fedoraproject.org/pipermail/legal/2011-August/001701.html a bit
too quickly.  I thought I should not do that, but on a second reading, I see
I'm allowed, (though not required).  I'll replace it as you suggest.

> I assume the upstream developer is gone for a long time

I actually could get in touch with the upstreams developer.  The e-mail address
in the package wasn't valid, but with a bit of googling I found him.  He would
consider doing a little update of the document, so maybe there will be an
updated version.  I've made the README file into a man page and sent him.  In
the mean time, I add it to the package as an additional source.

> The %defattr macro in the file list is obsolete

Right, I forgot.  And no, I have no plans to put it in EPEL.  I just forgot
this wasn't needed any more.

> Your package ships the FreeSans font, which is already available for Fedora

A good point.  After thinking a little, I made a patch that uses fontconfig to
find the file for the font FreeSans:Bold, and uses that instead of the bundled
version.  In addition to the obvious BuildRequires (fontconfig itself and
automake16), I also added gnu-free-sans-fonts as a regular Requires.

> To make your spec better readable, you should put all macros into brackets {}

On this point I would like to disagree.  I find those additional brackets
reducing readability.

Of course, it's not up to my taste, but what the guidelines says.  I looked for
some note on this point in the guidelines, but couldn't find anything.  But I
seem to remember this point was raised with some other package I was involved
in too.  I will ask on the packaging list for a "ruling".

Updated version:
SPEC: ftp://ftp.uddeborg.se/pub/mindless/mindless.spec
SRPM: ftp://ftp.uddeborg.se/pub/mindless/mindless-1.0.0-2.fc17.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.