[Bug 697049] Review Request: sawfish-pager - A pager for the Sawfish window manager
bugzilla at redhat.com
bugzilla at redhat.com
Mon Aug 15 18:37:45 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=697049
Mario Blättermann <mariobl at freenet.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #18 from Mario Blättermann <mariobl at freenet.de> 2011-08-15 14:37:44 EDT ---
$ rpmlint -i -v *
sawfish-pager.i686: I: checking
sawfish-pager.i686: W: spelling-error %description -l en_US viewport -> view
port, view-port, viewpoint
The value of this tag appears to be misspelled. Please double-check.
sawfish-pager.i686: W: spelling-error %description -l en_US workspaces -> work
spaces, work-spaces, works paces
The value of this tag appears to be misspelled. Please double-check.
sawfish-pager.i686: I: checking-url http://sawfish.wikia.com/ (timeout 10
seconds)
sawfish-pager.i686: E: incorrect-fsf-address
/usr/share/doc/sawfish-pager-0.90.2/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
sawfish-pager.x86_64: I: checking
sawfish-pager.x86_64: W: spelling-error %description -l en_US viewport -> view
port, view-port, viewpoint
The value of this tag appears to be misspelled. Please double-check.
sawfish-pager.x86_64: W: spelling-error %description -l en_US workspaces ->
work spaces, work-spaces, works paces
The value of this tag appears to be misspelled. Please double-check.
sawfish-pager.x86_64: I: checking-url http://sawfish.wikia.com/ (timeout 10
seconds)
sawfish-pager.x86_64: E: incorrect-fsf-address
/usr/share/doc/sawfish-pager-0.90.2/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
sawfish-pager.src: I: checking
sawfish-pager.src: W: spelling-error %description -l en_US viewport -> view
port, view-port, viewpoint
The value of this tag appears to be misspelled. Please double-check.
sawfish-pager.src: W: spelling-error %description -l en_US workspaces -> work
spaces, work-spaces, works paces
The value of this tag appears to be misspelled. Please double-check.
sawfish-pager.src: I: checking-url http://sawfish.wikia.com/ (timeout 10
seconds)
sawfish-pager.src: I: checking-url
http://download.tuxfamily.org/sawfishpager/sawfish-pager-0.90.2.tar.bz2
(timeout 10 seconds)
sawfish-pager-debuginfo.i686: I: checking
sawfish-pager-debuginfo.i686: I: checking-url http://sawfish.wikia.com/
(timeout 10 seconds)
sawfish-pager-debuginfo.x86_64: I: checking
sawfish-pager-debuginfo.x86_64: I: checking-url http://sawfish.wikia.com/
(timeout 10 seconds)
sawfish-pager.spec: I: checking-url
http://download.tuxfamily.org/sawfishpager/sawfish-pager-0.90.2.tar.bz2
(timeout 10 seconds)
5 packages and 1 specfiles checked; 2 errors, 6 warnings.
OK, no recognizable issues, given the discussions earlier in this review.
---------------------------------
key:
[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPLv2+
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
e84286703e550cb7f4da15934f6e207f sawfish-pager-0.90.2.tar.bz2
e84286703e550cb7f4da15934f6e207f sawfish-pager-0.90.2.tar.bz2.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
Works fine with Sawfish 1.8.1 on F15.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[.] SHOULD: Your package should contain man pages for binaries/scripts.
----------------
PACKAGE APPROVED
----------------
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list