[Bug 710905] Review Request: octave-optim - Optimization for Octave

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=710905

--- Comment #5 from Jussi Lehtola <jussi.lehtola at iki.fi> 2011-08-16 03:30:09 EDT ---
rpmlint output:
octave-optim.src:11: W: macro-in-comment %40unreal
octave-optim.x86_64: W: obsolete-not-provided octave-forge
octave-optim.x86_64: W: hidden-file-or-dir
/usr/share/octave/packages/optim-1.0.16/packinfo/.autoload
octave-optim.x86_64: E: zero-length
/usr/share/octave/packages/optim-1.0.16/packinfo/.autoload
octave-optim.x86_64: W: dangerous-command-in-%preun cp
3 packages and 0 specfiles checked; 1 errors, 4 warnings.

These are expected.

**

You are using the noarch template for arch dependent packages. This is why I
ran recently into trouble with two of your existing packages. Replace
 Requires:       octave
with
 Requires:       octave(api) = %{octave_api}

**

The command

for i in %{octpkgdir}/doc/figures/2D_slice-3.eps2
%{octpkgdir}/doc/figures/optim_tutorial_slice.eps; do
  iconv -f iso8859-1 -t utf-8 %{buildroot}/$i > %{buildroot}/$i.conv && mv -f
%{buildroot}/$i.conv %{buildroot}/$i
done;

looks *really* odd. Did you get an rpmlint warning about text in the wrong
encoding? I'm not a PostScript expert, but I'd leave these files as-is.

**

Your summary is sloppy. Please change it to something of the lines of "A
non-linear optimization tool kit for Octave".

Also the description could be better, along the lines of

This package contains a non-linear optimization tool kit for Octave, containing
functions for curve fitting and the following minimization algorithms:
* Nead-Miller simplex
* Conjugate Gradients
* Memory limited BFGS
* Simulated Annealing

**

MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
NEEDSWORK
- As far as I can see, this is plain GPLv2+.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
$ md5sum optim-1.0.16.tar.gz ../SOURCES/optim-1.0.16.tar.gz 
a0ed1c8bbd7d9ddafc6f5fab08aba1c5  optim-1.0.16.tar.gz
a0ed1c8bbd7d9ddafc6f5fab08aba1c5  ../SOURCES/optim-1.0.16.tar.gz

MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A

MUST: Optflags are used and time stamps preserved. ??
- The optimization flags aren't shown in the build process. Everything seems to
be alright, though.

MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned, architecture dependent dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
EPEL: Clean section exists. OK
EPEL: Buildroot cleaned before install. OK
EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.