[Bug 730764] Review Request: wxpdfdoc - A library for creating PDF documents in C++ with wxWidgets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=730764

--- Comment #1 from Domingo Becker <domingobecker at gmail.com> 2011-08-16 11:34:52 EDT ---
The x86_64 installation problem (lib for lib64) has been fixed with a patch
that applies only to this achitecture.

Spec URL: http://beckerde.fedorapeople.org/wxpdfdoc/wxpdfdoc.spec

Patch URL: http://beckerde.fedorapeople.org/wxpdfdoc/GNUmakefile.patch

SRPM URL:
http://beckerde.fedorapeople.org/wxpdfdoc/wxpdfdoc-0.9.1-2.fc14.src.rpm

New Koji Build (successful build):
http://koji.fedoraproject.org/koji/taskinfo?taskID=3276084


rpmlint on the spec file:

[user at computer ~]$ rpmlint -i ~/rpmbuild/SPECS/wxpdfdoc.spec 
/home/user/rpmbuild/SPECS/wxpdfdoc.spec:49: W: rpm-buildroot-usage %build make
-C build prefix=$RPM_BUILD_ROOT%{_prefix} all -f GNUmakefile
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may
break short circuit builds.

/home/user/rpmbuild/SPECS/wxpdfdoc.spec: W: %ifarch-applied-patch Patch0:
GNUmakefile.patch
A patch is applied inside an %ifarch block. Patches must be applied on all
architectures and may contain necessary configure and/or code patch to be
effective only on a given arch.

0 packages and 1 specfiles checked; 0 errors, 2 warnings.
[user at computer ~]$ 


rpmlint on the srpm: 

[user at computer ~]$ rpmlint -i ~/rpmbuild/SRPMS/wxpdfdoc-0.9.1-2.fc14.src.rpm 
wxpdfdoc.src: W: spelling-error Summary(en_US) wxWidgets -> widgets, widget,
midgets
The value of this tag appears to be misspelled. Please double-check.

wxpdfdoc.src: W: spelling-error %description -l en_US wxWidgets -> widgets,
widget, midgets
The value of this tag appears to be misspelled. Please double-check.

wxpdfdoc.src:49: W: rpm-buildroot-usage %build make -C build
prefix=$RPM_BUILD_ROOT%{_prefix} all -f GNUmakefile
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may
break short circuit builds.

wxpdfdoc.src: W: %ifarch-applied-patch Patch0: GNUmakefile.patch
A patch is applied inside an %ifarch block. Patches must be applied on all
architectures and may contain necessary configure and/or code patch to be
effective only on a given arch.

1 packages and 0 specfiles checked; 0 errors, 4 warnings.
[user at computer ~]$ 


Comments: 
- there's no spelling error, it's wxWidgets.
- it is necessary to change the prefix variable used inside GNUmakefile during
the build process.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.